Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values, update form-data version and handling empty server command inputs.#78
Closed
Harshi-Shah-CS wants to merge 20 commits intomainfrom
Conversation
CL-2062 | +Harshi | Fix skip environment variables option with --vari…
fix: suppress error message in non-development environments
Add AGENTS.md file
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to support multiple selections
fix: handle empty server command input properly
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs.
Update form-data to 4.0.4 and add dependency overrides
fix: Update form-data to 4.0.4 and add dependency overrides
There was a problem hiding this comment.
Pull request overview
This PR implements multiple fixes related to environment variable handling, Apollo client message suppression, and server command input validation. It updates dependencies and adds comprehensive test coverage for the new functionality.
Key Changes:
- Adds global console patching to suppress Apollo client deprecation warnings in non-development environments
- Implements proper environment variable parsing for URL-formatted values (values containing colons)
- Enables the
--variable-typeflag to accept multiple values for flexible environment variable configuration - Improves server command handling to properly skip empty or whitespace-only inputs
- Updates form-data to exact version 4.0.4 and @apollo/client to ^3.14.0 with package overrides for transitive dependencies
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/apollo-client.ts | Adds global console patching to filter Apollo-specific error/warning messages when not in development mode |
| src/util/logs-polling-utilities.ts | Implements withDeprecationsDisabled wrapper to suppress Apollo deprecation warnings during query execution |
| src/adapters/base-class.ts | Adds parseEnvVariablesString method for URL-safe parsing and converts string variableType to array for consistent handling |
| src/adapters/github.ts | Updates server command handling to conditionally include field only when non-empty after trimming |
| src/adapters/file-upload.ts | Mirrors github.ts server command handling improvements |
| src/commands/launch/index.ts | Enables multiple flag support for --variable-type and updates documentation |
| test/unit/util/apollo-client.test.ts | New test file covering console suppression behavior in development vs non-development environments |
| src/adapters/github.test.ts | Adds comprehensive tests for deployment flow and server command prompt scenarios |
| src/adapters/file-upload.test.ts | New test file mirroring github.test.ts coverage for file upload adapter |
| src/adapters/base-class.test.ts | Expands tests for variable type handling including string-to-array conversion and multiple option combinations |
| package.json | Updates @apollo/client to ^3.14.0, pins form-data to 4.0.4, adds overrides for axios and form-data |
| package-lock.json | Reflects dependency updates with axios 1.10.0 for nested packages and form-data 4.0.4 throughout |
| AGENTS.md | New file documenting testing conventions and guidelines for agent-assisted development |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
venky0195
previously approved these changes
Dec 11, 2025
SakshiKoli-CS
previously approved these changes
Dec 11, 2025
chore: update version in package.json file
Update version in package.json file from 1.9.3 to 1.9.4
Harshi-Shah-CS
dismissed stale reviews from SakshiKoli-CS and venky0195
via
fb88241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Update form-data to 4.0.4
fix: skip environment variables option with --variable-type flag
fix: suppress error message in non-development environments
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to accept multiple values
fix: handle empty server command input properly